Posts made by rui_mac

The addition of the undo as a flag is great. Thank you :-)

What was not working was that, in R21, I was getting no spline as the return result of the SendModelingCommand, set to MCOMMAND_EDGE_TO_SPLINE.
I will try again, at home, as I don't have R21 here, at work.

Thank you, Manuel.

From what I see, several things are working differently in R21.
I suspect the MCOMMAND_EDGE_TO_SPLINE is also not working properly.
And the MCOMMAND_CURRENTSTATETOOBJECT (a very important one) is also not working as expected, requiring that the object to be converted to be in a new document.

I will start using IsInstanceOf instead of GetType :-)

I will also pay more attention to the tagging part of my posts.

Once again, thank you.

I finally made it work without the error after hitting undo, by replacing calls to GetLength, in the form:

GetLength(op,p1,p2)

to

GetLength(op.GetClone(),p1,p2)

@m_magalhaes said in Error after hitting Undo.:

I've also marked this thread as a question as you seem to never do it ;p

How can I mark it as a question?

I made the changes in order to work on a duplicate of the original spline.
It still works, but it also still returns the same error when I undo.
Here is the script:

import c4d
from c4d import gui
# Welcome to the world of Python

# Find the length of the spline segment between points p1 and p2
def GetLength(op,p1,p2):
    select=op.GetPointS()
    select.DeselectAll()
    select.Select(p1)
    select.Select(p2)

    bc=c4d.BaseContainer()
    result=c4d.utils.SendModelingCommand(c4d.MCOMMAND_SPLIT, [op], mode=c4d.MODELINGCOMMANDMODE_POINTSELECTION, bc=bc, doc=doc)
    leng=10000000.0
    if result!=False and result!=[]:
        op2=result[0]
        segm=c4d.utils.SplineHelp()
        segm.InitSplineWith(op2, flags=c4d.SPLINEHELPFLAGS_GLOBALSPACE|c4d.SPLINEHELPFLAGS_CONTINUECURVE)
        leng=segm.GetSplineLength()
        segm.FreeSpline()
    return leng

# Main function
def main():
    selected=doc.GetActiveObjects(c4d.GETACTIVEOBJECTFLAGS_0)
    if len(selected) == 0:
        c4d.gui.MessageDialog("You must select a spline and two consecutive points of that spline.")    
        return

    op=selected[0]
    if op.GetType()!=5101:
        c4d.gui.MessageDialog("You must select a spline and two consecutive points of that spline.")    
        return

    selection=op.GetPointS()
    if selection.GetCount()!=2:
        c4d.gui.MessageDialog("You must select two consecutive points of the spline.")
        return

    # check if the selected points are consecutive
    p1,p2=-1,-1
    num=op.GetPointCount()
    for s in range(num):
        if selection.IsSelected(s):
            if p1==-1:
                p1=s
            else:
                p2=s

    if p2-p1!=1:
        c4d.gui.MessageDialog("You must select two consecutive points of the spline.")
        return

    # get the size of the segment
    shortest=GetLength(op,p1,p2)
    
    # work on a copy of the original spline
    op2=op.GetClone()

    # start at point 0
    i=0
    while i<num:
        # get the length of the current segment between point i and i+1
        new_length=GetLength(op2,i,i+1)

        # if the segment is, at least one and a half times the size of the initial segment...
        if (new_length>(shortest*1.5)):
            subdivs=int(new_length/shortest)+1

            # select point i and i+1
            selection=op2.GetPointS()
            selection.DeselectAll()
            selection.Select(i)
            selection.Select(i+1)

            # subdivide that segment
            bc=c4d.BaseContainer()
            bc.SetInt32(c4d.MDATA_SUBDIVIDE_SPLINESUB,subdivs)
            result=c4d.utils.SendModelingCommand(c4d.MCOMMAND_SUBDIVIDE, [op2], mode=c4d.MODELINGCOMMANDMODE_POINTSELECTION, bc=bc, doc=doc)
            
            # update the counter
            i=i+subdivs-1
            # update the limit
            num=num+subdivs-1
        
        # increase the counter
        i=i+1

    # insert the new subdivided spline after the original spline
    # and delete the original spline, making sure this is undoable
    doc.StartUndo()
    doc.InsertObject(op2, parent=None, pred=op, checknames=False)
    doc.AddUndo(c4d.UNDOTYPE_NEW, op2)
    doc.AddUndo(c4d.UNDOTYPE_DELETE, op)    
    op.Remove()
    doc.EndUndo()
    
    # update the document
    c4d.EventAdd()

# Execute main()
if __name__=='__main__':
    main()

I created a script that performs a few subdivisions on splines, using the SendModelingCommand command, with the MCOMMAND_SUBDIVIDE.
It performs the subdivision on segments of the spline between selected points. I tried adding undos, so that hitting Undo after the script executes, would return the original spline, without subdivisions.
However, after hitting Undo, I get an error:

A problem with this project as been detected: Object 'Spline' - Point selection out of bounds.
Please save and contact Maxon Support with a description of the last used commands, actions or plugins.

I start my script with two consecutive points along the spline selected.
Besides this error, if I hit Undo, the code works fine.
What could be the problem?

I removed the KillDocument() and the IRR works now. So, it was the culprit.
I had added the KillDocument() because if some hangs when testing the code that seemed like some memory leaks and I since I didn't know that python performed automatic garbage collection, I was trying to delete everything that I created in my code.
I remember, back in COFFEE that I could perform a manual gc()
So, this is done automatically in python? Good to know.
As the code is working fine now, I consider this as solved.
I will test some more to see if the previous crashes are repeatable.
Thank you, Riccardo.

The difference in this Object plugin is that I create two temporary documents with IsolateObjects(), and after getting the required objects created in the new temporary documents, I KillDocument() both at the end.
Could this be it?

I can't even know what type of information I can provide to start solving this.
My Object plugin is working fine and producing the correct mesh.
When I perform a render in the window or in the Picture Viewer, everything is fine.
But, as I turn on Interactive Render Region, Cinema 4D hangs.
What could cause this?

It is working now. However, after a while, I got an error that it looked like a memory leak or something similar.
I'm using c4d.documents.IsolateObjects to create a new temporary document.
Do I need to delete that new document, after performing the MCOMMAND_CURRENTSTATETOOBJECT?

Also, replacing the MCOMMAND_CURRENTSTATETOOBJECT with MCOMMAND_MAKEEDITABLE, I get this error:

ReferenceError: the object 'c4d.BaseObject' is not alive

Oh, another information that could be important.
This is an Object plugin. And, when testing, if I simply return the Sweep object, it generates the correct mesh (although, I require a polygonal mesh because I still have to do some operations on the faces).
But, if I press the C key, the Object plugin generates a simple Sweep Generator, without any children.

This is my code

...
version_number=c4d.GetC4DVersion()		
main_sweep=c4d.BaseObject(c4d.Osweep)

main_sweep[c4d.SWEEPOBJECT_GROWTH]=completeness
main_sweep[c4d.SWEEPOBJECT_SPLINESCALE]=spline_scale
main_sweep[c4d.SWEEPOBJECT_ROTATE]=twist1

if version_number<21000:		
	main_sweep[c4d.CAP_START]=close_start
	main_sweep[c4d.CAP_END]=close_end
	main_sweep[c4d.CAP_TYPE]=2
else:
	main_sweep[c4d.CAPSANDBEVELS_CAP_ENABLE_START]=close_start
	main_sweep[c4d.CAPSANDBEVELS_CAP_ENABLE_END]=close_end
	main_sweep[c4d.CAPSANDBEVELS_CAP_TYPE]=2		

# insert the  path inside the SweepNURBS
new_spline.InsertUnder(main_sweep)
# insert the profile inside the SweepNURBS
main_profile=c4d.BaseObject(c4d.Osplinerectangle)
main_profile[c4d.PRIM_RECTANGLE_WIDTH]=profile_size
main_profile[c4d.PRIM_RECTANGLE_HEIGHT]=profile_size
main_profile.InsertUnder(main_sweep)

the_mode=c4d.MODELINGCOMMANDMODE_ALL
if version_number<21000:
	the_mode=c4d.MODIFY_ALL

result=utils.SendModelingCommand(command=c4d.MCOMMAND_CURRENTSTATETOOBJECT,list=[main_sweep],mode=the_mode,bc=c4d.BaseContainer(),doc=doc)

The result variable returns this:

[<c4d.BaseObject object called 'Sweep/Null' with ID 5140 at 0x149102450>]

It is simply a Null without any children.
I know that the Sweep is fine, because when I return just the Sweep, I get the correct Sweep. But I need it be a polygonal object, not a Generator.
What could be happening?

Will do, as soon as I get home.
Thank you.

I'm adjusting the code of my plugins to make then work in R21.
One of them creates, internally, a Sweep that is then converted to a polygonal object through a SendModelingCommand, set to CurrentStateTo Object.
The plugin works fine until R20, but in R21, the SendModelingCommand (set to CSTO), returns a Null.
Did anything changed and needs to be done differently?

Is there any way to detect, inside a shader plugin, that the code is being executed to produce the Material Editor thumbnail preview or of it is being executed on an editor or Picture Viewer render?

I had to ask, since your name is so "portuguese" :-)

Well, since this is a plugin that I had already coded in python, I don't think I will be converting it to C++.
But in the future I know now that I will need to start a project that requires this type of control, in C++.

Tell me... Manuel Magalhães... are you portuguese?

I didn't realized this would qualify as a new functionality. Sorry.
In fact, I don't want it to be drawn behind other objects.
It is supposed to show as a floating layer on top of everything else.

I'm drawing a bitmap on the viewport using DrawTexture but, if the Depth of Field option is turned on and depending on the camera settings, the bitmap is drawn out of focus.
Is there a way to make DrawTexture always draw the bitmap without any blurring, no matter if the Depth of Field option is on or off?
Thank you very much in advance for any reply.