There is stricter error checking now. You will need to do the following...

while (file->ReadChar(&ch)) {
        iferr(text.AppendChar(ch)) {
            return; //Handle the error
     }
}

Those steps look correct. But it should be noted that you should be using the correct version of Cinema 4D to compile for R20 (VS 2015) and R21 (VS 2017). It might work using VS 2019, if you change the Standard Language as mentioned. But it may still link to newer dlls which won't be installed on users machines. So using the correct VS version will ensure the dlls required will already be installed by the C4D installer. And the Support team here can't provide you any support if you are using the wrong version of VS.

https://developers.maxon.net/?page_id=1108

Hi @r_gigante ,

Thanks for the code. I have it working now in R20. The issue seems to be that for R20 the interface file needs to be part of a framework. This is not the case for R21. In R21 I could include all the code locally within my plugin and it worked fine, but for R20 it needed to be extracted out to the frameworks folder as shown in your example. I didn't need to create a new module (ie its own xdl64) since I can register the framework from within my main plugin itself. So I have a working solution now.

This is another reason why I would really like to have the ability to include our own framework folder in the projectdefinition.txt file. Mixing it in with the regular SDK ones is really not ideal.

Thanks again for the example code.

Cheers,
Kent

@PluginStudent said in Fun with maxon::BaseArray:

Just some note: please use proper error handling in your code e.g. implementing iferr_scope_handler.

Putting iferr() {} everywhere is pretty bad style no one should copy.

I think here @C4DS is just quickly writing a test scenario to highlight the problem. Not a complete final implementation.

Thanks @r_gigante. Looking forward to it.

Cheers,
Kent

One additional piece of information I just found. In the Output in VS I see this when the breakpoint hits.

../../core.framework/generated/hxx/objectbase1.hxx(441): CRITICAL: Module net.maxon.c4d.cinema.framework attempts to initialize com.gamelogicdesign.error.api of different module com.gamelogicdesign.pluginmanager [caused by com.gamelogicdesign.error.api]. [object_impl.cpp(2379)]
CINEMA 4D.exe has triggered a breakpoint.

The message seems strange to me since the error is in the same "module" (ie plugin). I even tried giving the error id a similar path such as com.gamelogicdesign.pluginmanager.error.api but it had a similar warning, just displaying this identifier instead.

@r_gigante

Even though my solution compiles now for R20, when I return an error it hits an assert somewhere internally in C4D.

Would it be possible for you to create a full working example of a Custom Error that works in R20 so that I can see exactly what you have added to your files? With all of these pre-processor issues and fancy macros it is hard to know what we need to add to make things work.

I don't know what to add to make it work in R20, works fine in R21 using the changes mentioned above from the latest docs. But for R20 it just asserts every time I return my custom error.

My problem may be due to the following, since I am not using either of these yet.

Where, when and how do you use these?

I am introducing additional methods so I can't use the second one (even though I have no idea how or when you would use it). But perhaps I need to use the first one somewhere? Is it between the two generated headers? If so then why does it work fine without this call in R21?

I am using MAXON_COMPONENT_OBJECT_REGISTER as mentioned in the docs. Is this wrong? Are the docs wrong?

Thanks in advance,
Kent

Here is my error...

CINEMA 4D.exe!00007ff6ddacd841()	Unknown
testplugin.xdl64!maxon::Declaration<ApiError,ApiErrorObjectPrivateHelper>::operator()<&maxon::`anonymous namespace'::g_translationUnit,0>() Line 567	C++
testplugin.xdl64!ApiErrorInterface::COWReferenceFunctionsImpl<maxon::ErrorInterface::COWReferenceFunctionsImpl<maxon::Object::COWReferenceFunctionsImpl<maxon::RefBaseFunctions<maxon::DirectRef<ApiErrorInterface const ,maxon::StrongCOWRefHandler,ApiError> > > > >::Create(const maxon::SourceLocation & allocLocation, ApiResult result, APIErrorData data) Line 49	C++

This is where the error occurs in module.h

Hi @r_gigante

I believe my solution is the correct one since I got this change from the official C4D documentation by comparing the code from R20 and R21 in the docs.

Here is the documentation from R20

And here is the documentation from R21

On a side note, the documentation is very unclear how you should use code like this. The main point that is never discussed is that in your header file you should include the generated files, in my case apierror1.hxx and apierror2.hxx. Working examples for these error codes (and all other Maxon API examples) with a full .h and .cpp file would be great to include directly in the documentation itself, ie not code snippets, but the full usable code.

Cheers,
Kent

Problem solved. There was a change in the API from R20 to R21.

Wrapping the code in your header interface definition like shown below will allow Custom Errors to compile in both.

#if API_VERSION >= 20000 && API_VERSION < 21000
* static_cast<typename S::DirectlyReferencedType::ReferenceClassHelper::type*>(this) = S::DirectlyReferencedType::ReferenceClassHelper::object::GetInstance() ();
#elif API_VERSION >= 21000  && API_VERSION < 22000
*static_cast<typename S::DirectlyReferencedType::Hxx1::ReferenceClass*>(this) = S::DirectlyReferencedType::Hxx1::ErrObj::GetInstance()();
#endif